Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement update test data #22

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

implement update test data #22

wants to merge 9 commits into from

Conversation

bernt-matthias
Copy link
Collaborator

@bernt-matthias bernt-matthias commented Sep 6, 2021 •
edited
Loading

  • set the number of chunks to 1 in setup mode
    • because otherwise CI would need to push from multiple chunks
  • add --update-test-data to test mode

@bernt-matthias bernt-matthias mentioned this pull request Sep 6, 2021
Open
5 tasks
@bernt-matthias bernt-matthias force-pushed the topic/update-test-data branch 2 times, most recently from aa3c74f to 467ccdb Compare September 7, 2021 08:50
@bernt-matthias
implement update test data
467ccdb 
which sets #chunks to 1 during update
and adds --update-test-data to test
@mvdbeek
Copy link
Member

mvdbeek commented Sep 7, 2021

So how do we get the test data, we upload them as an artifact or we push them back to the branch ?

@bernt-matthias
Copy link
Collaborator Author

So how do we get the test data, we upload them as an artifact or we push them back to the branch ?

I thought about pushing to the branch.

@bernt-matthias bernt-matthias marked this pull request as draft September 8, 2021 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bernt-matthias @mvdbeek