Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metabomics-lcms-preprocessing WF #292

Merged
merged 15 commits into from
Nov 23, 2023

Conversation

lecorguille
Copy link
Member

Here is a first WF for metabolomics link to this GTN.

It would be great to have it in WorkflowHub.eu. We plan a paper which will refere to.

@mvdbeek
Copy link
Member

mvdbeek commented Nov 21, 2023

Thanks @lecorguille, can you please have a look at the steps in https://github.com/galaxyproject/iwc/blob/main/workflows/README.md#adding-workflows ?

@lecorguille
Copy link
Member Author

Thanks @lecorguille, can you please have a look at the steps in https://github.com/galaxyproject/iwc/blob/main/workflows/README.md#adding-workflows ?

Should be ok now?

@mvdbeek
Copy link
Member

mvdbeek commented Nov 21, 2023

Yes, looks better but you're still missing the readme and changelog.

@lldelisle
Copy link
Contributor

Also, could you rename the _test.yml to -tests.yml? Thanks

@lecorguille lecorguille changed the title Add metabomics-lcms-preprocessing WF Draft: Add metabomics-lcms-preprocessing WF Nov 22, 2023
@lecorguille lecorguille changed the title Draft: Add metabomics-lcms-preprocessing WF Add metabomics-lcms-preprocessing WF Nov 22, 2023
Copy link
Member

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to create a metabolomics folder under workflows/ ?
So your first workflow would then be in the workflows/metabolomics/lcms-preprocessing ?

workflows/metabomics-lcms-preprocessing/README.md Outdated Show resolved Hide resolved
workflows/metabomics-lcms-preprocessing/README.md Outdated Show resolved Hide resolved

The content of your sample metadata file has to be filled by you, since it is not contained in your raw data. Note that you can either:
- Upload an existing metadata file
- Use a template to create one (because it can be painful to get the sample list without misspelling or omission)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to provide a link to a template here (or link to the corresponding tutorial section) ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As explained the line after, the template can be generated with the xcms get a sampleMetadata file tool.

The tool will fill the samplename based on the infile names.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to create a metabolomics folder under workflows/ ?
Done 👍

workflows/metabomics-lcms-preprocessing/README.md Outdated Show resolved Hide resolved
@lecorguille
Copy link
Member Author

How can I generate a .workflowhub.yml?

@mvdbeek
Copy link
Member

mvdbeek commented Nov 22, 2023

You don't have to, that's autogenerated

@lldelisle
Copy link
Contributor

Could you rename the '-test.yml' to '-tests.yml' (the documentation is wrong, I just realized) and regenerate the .dockstore.yml, please? (planemo dockstore_init .)
For the moment, there is no test in the dockstore so the CI does not test.

@lecorguille
Copy link
Member Author

lecorguille commented Nov 22, 2023

Could you rename the '-test.yml' to '-tests.yml' (the documentation is wrong, I just realized)

Done

and regenerate the .dockstore.yml, please? (planemo dockstore_init .)

Already done, isn't it?

@lldelisle
Copy link
Contributor

You need to regenerate it after having renamed your test, this way, it will add something like:

testParameterFiles:
- /atacseq-tests.yml

@lldelisle
Copy link
Contributor

Apparently the renaming was sufficient to run the CI but it is better is you tell dockstore that you have a test file.

@lecorguille
Copy link
Member Author

Oups, sorry, I missed the re in regenerate

@lldelisle
Copy link
Contributor

No problem.

Copy link
Member

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great from my side, what do you think @lldelisle ?

@lldelisle
Copy link
Contributor

After this small correction in the README, it is good for me also.

@lldelisle lldelisle merged commit cc6f30f into galaxyproject:main Nov 23, 2023
1 check passed
@lldelisle
Copy link
Contributor

Youhou! I am super happy to have new workflows in IWC.

@lecorguille lecorguille deleted the w4m_lcms branch November 23, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants