-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metabomics-lcms-preprocessing WF #292
Add metabomics-lcms-preprocessing WF #292
Conversation
Thanks @lecorguille, can you please have a look at the steps in https://github.com/galaxyproject/iwc/blob/main/workflows/README.md#adding-workflows ? |
Should be ok now? |
Yes, looks better but you're still missing the readme and changelog. |
Also, could you rename the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to create a metabolomics folder under workflows/ ?
So your first workflow would then be in the workflows/metabolomics/lcms-preprocessing
?
|
||
The content of your sample metadata file has to be filled by you, since it is not contained in your raw data. Note that you can either: | ||
- Upload an existing metadata file | ||
- Use a template to create one (because it can be painful to get the sample list without misspelling or omission) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to provide a link to a template here (or link to the corresponding tutorial section) ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As explained the line after, the template can be generated with the xcms get a sampleMetadata file tool.
The tool will fill the samplename based on the infile names.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to create a metabolomics folder under workflows/ ?
Done 👍
...lows/metabomics-lcms-preprocessing/Mass_spectrometry__LC-MS_preprocessing_with_XCMS-test.yml
Outdated
Show resolved
Hide resolved
Co-authored-by: Marius van den Beek <[email protected]>
Co-authored-by: Marius van den Beek <[email protected]>
Co-authored-by: Marius van den Beek <[email protected]>
…MS_preprocessing_with_XCMS-test.yml Co-authored-by: Marius van den Beek <[email protected]>
How can I generate a .workflowhub.yml? |
You don't have to, that's autogenerated |
Could you rename the '-test.yml' to '-tests.yml' (the documentation is wrong, I just realized) and regenerate the |
Done
Already done, isn't it? |
You need to regenerate it after having renamed your test, this way, it will add something like: iwc/workflows/epigenetics/atacseq/.dockstore.yml Lines 7 to 8 in 7fbbd2a
|
Apparently the renaming was sufficient to run the CI but it is better is you tell dockstore that you have a test file. |
Oups, sorry, I missed the re in regenerate |
No problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great from my side, what do you think @lldelisle ?
After this small correction in the README, it is good for me also. |
Co-authored-by: Lucille Delisle <[email protected]>
Youhou! I am super happy to have new workflows in IWC. |
Here is a first WF for metabolomics link to this GTN.
It would be great to have it in WorkflowHub.eu. We plan a paper which will refere to.