[19.05] Re-version 19.05 as 19.05 - introducing the new 19.05.

[jmchilton]

[jmchilton]

dev got merged into 19.05 at some point, we don't really know when or how but we decided it would probably just be safest to call the thing on usegalaxy.org right now release_19.05.

[natefoo]

It'd be cool if we could at least figure out how/when. Interesting that git makes this so difficult.

[nsoranzo]

I think the issue is commit ee89a48, which was pushed to the release_19.05 branch (in addition to dev).

[natefoo]

@nsoranzo Ah, good catch! How'd you find it?

[dannon]

@natefoo I posted it on Gitter last night. I still don't understand the PR reference on that commit, though.

(to elaborate, the way I found it was basically manually bisecting to check for the version string on all merge commits to release_19.05, since (as you found out as well) the automated bisect just finds the source commit)

[natefoo]

@dannon ah thanks!

For the record:

I generated it doing something like git log --no-merges allgood..nobueno to find the substantive commit differences.
Where allgood and nobueno are branches checked out at af95770 and ee89a48 respectively.

[martenson]

+0.1

I think we should backport #7935.

fwiw these are the PRs that got to release and shouldn't:

#7746
#7827
#7858
#7874
#7859
#7860
#7840

in addition to the merge commit being weird, this one is also weird

[nsoranzo]

@nsoranzo Ah, good catch! How'd you find it?

I just grepped the output of git log release_19.05 for the most recent Merge ...release_19.05' into dev.

The last "correct" commit @dannon mentions (af95770) is simply the right parent of ee89a48 .

[dannon]

@natefoo That command was for generating https://gist.github.com/dannon/b4bb6dc5c470311957500d34eee01961, which was the extra changesets included.

[natefoo]

D'oh

[dannon]

I'll backport #7935.

[jmchilton]

Fixed up PR tags - re-tagging those listed by @martenson and went through a bunch of older 19.09 PRs not listed and made sure they weren't in release_19.05. Thanks all.