Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using the rule based collection builders right from libraries. #5929

Merged
merged 5 commits into from
Apr 24, 2018

Conversation

jmchilton
Copy link
Member

Fuses recent additions allowing creation of collections from libraries (#5080) and creating arbitrary collections from the rule builder (#5365).

Requested by @mblue9 on #5381 (comment) who is providing awesome feedback on the new rule based collection builder. She lays out the potential for this to save dozens of clicks when importing collections from libraries.

@martenson
Copy link
Member

martenson commented Apr 23, 2018

because of how the library router works the 'fake' links href="#" in the rule builder will have effects on navigation within libraries (the application under the rule builder modal reacts and goes to the library index)

@martenson
Copy link
Member

{"traceback": "Traceback (most recent call last):\n File \"lib/galaxy/web/framework/decorators.py\", line 281, in decorator\n rval = func(self, trans, *args, **kwargs)\n File \"lib/galaxy/webapps/galaxy/api/history_contents.py\", line 393, in create\n return self.__create_dataset_collection(trans, history, payload, **kwd)\n File \"lib/galaxy/webapps/galaxy/api/history_contents.py\", line 530, in __create_dataset_collection\n **create_params\n File \"lib/galaxy/managers/collections.py\", line 100, in create\n validate_input_element_identifiers(element_identifiers)\n File \"lib/galaxy/managers/collections_util.py\", line 52, in validate_input_element_identifiers\n raise exceptions.RequestParameterInvalidException(message)\nRequestParameterInvalidException: Found duplicated element identifier name 1.bam.\n", "err_msg": "Found duplicated element identifier name 1.bam.", "err_code": 400008}

libraries allow datasets with same name

@martenson
Copy link
Member

When rendering the rows for the preview the rulebuilder-css affects the global cascade and all rows within libraries become very short in the y-axis even after closing the modal. Needs hard reload to get rid of.

screenshot 2018-04-23 14 51 05

after hard reload:
screenshot 2018-04-23 14 53 19

@jmchilton
Copy link
Member Author

libraries allow datasets with same name

So does the uploader and and then history panel - they will all suffer from the same poor validation checking here I think.

@jmchilton
Copy link
Member Author

CSS problem is handsontable - I'm looking into it also:

screen shot 2018-04-23 at 3 09 12 pm

- Print a pretty error for this scenerio.
- Improve the error state of the widget to add a cancel and "okay" button - the cancel button dimisses the widget and the okay button gives the reseracher a chance to return to the rules and try again.
@jmchilton
Copy link
Member Author

Three commits with various fixes - one commit per comment above from @martenson (library router, CSS contamination, and better handling of duplicate identifier errors).

@martenson martenson merged commit 393f436 into galaxyproject:dev Apr 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants