-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow using the rule based collection builders right from libraries. #5929
Conversation
d90eeb3
to
861e854
Compare
because of how the library router works the 'fake' links |
libraries allow datasets with same name |
So does the uploader and and then history panel - they will all suffer from the same poor validation checking here I think. |
3899ce4
to
8ae656b
Compare
8ae656b
to
7fd12ec
Compare
- Print a pretty error for this scenerio. - Improve the error state of the widget to add a cancel and "okay" button - the cancel button dimisses the widget and the okay button gives the reseracher a chance to return to the rules and try again.
Three commits with various fixes - one commit per comment above from @martenson (library router, CSS contamination, and better handling of duplicate identifier errors). |
Fuses recent additions allowing creation of collections from libraries (#5080) and creating arbitrary collections from the rule builder (#5365).
Requested by @mblue9 on #5381 (comment) who is providing awesome feedback on the new rule based collection builder. She lays out the potential for this to save dozens of clicks when importing collections from libraries.