Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide outdated visualizations from visualizations activity panel #19353

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

guerler
Copy link
Contributor

@guerler guerler commented Dec 19, 2024

This PR introduces a visibility flag to the visualization XML, allowing legacy visualizations to be hidden from the visualizations activity panel when users create new visualizations. However, previously saved legacy visualizations will still be accessible via the saved visualizations grid.

The deprecated visualizations include nvd3 and jqplot. Going forward, plotly is the recommended choice. It not only provides enhanced functionality and better support compared to the legacy visualization types but also utilizes a modern vite/vue3-based build system that is far more reliable. Previously, visualizations needed to be rebuilt within the context of the Galaxy client, which often resulted in build failures. With the new system, visualizations are built independently of Galaxy client internals and build bundles, and then published to npm, ensuring a more streamlined and robust process.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@guerler guerler added this to the 25.0 milestone Dec 19, 2024
@guerler guerler marked this pull request as ready for review December 19, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant