Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use popper wrapper for help text popover #19340

Merged
merged 4 commits into from
Dec 18, 2024

Conversation

guerler
Copy link
Contributor

@guerler guerler commented Dec 17, 2024

Requires #19337. Improves alignment, arrow position, scrolling behavior and prevents help text popover to be cut off on small screens.

Previous:
Screenshot 2024-12-17 at 7 25 22 PM

Now:
popper2

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@guerler guerler force-pushed the consistent_help_popper branch from aef5d5c to 8347fc5 Compare December 17, 2024 17:47
@guerler guerler marked this pull request as ready for review December 18, 2024 09:48
@mvdbeek mvdbeek merged commit 4684800 into galaxyproject:dev Dec 18, 2024
30 checks passed
@mvdbeek
Copy link
Member

mvdbeek commented Dec 18, 2024

Cool, thank you!

@guerler guerler deleted the consistent_help_popper branch December 27, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants