Use collection hids for collection inputs in dataset names #19229
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For input of dataset collections to
data_collection
inputs ordata
inputs withmultiple="true"
the dataset name (on_string
) lists the HIDs of the datasets in the input collections. This makes it more difficult than necessary to understand the history. It would be better to list the input collections.This PR does 2 things:
on_string
from"data 1, data 2, and data 3"
to"dataset 1, 2, and 3"
and analogous for collections.Discussion:
dataset
we could stick withdata
collection
we could uselist
.. to me it seems that the terms are used interchangeably .. ultimately we should decide for oneTODO:
Fixes #7467
Before (using the identifier_multiple test tool for multiple data input):
Screencast.from.02.12.2024.13.22.58.webm
After:
Screencast.from.02.12.2024.13.14.30.webm
How to test the changes?
(Select all options that apply)
License