Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use collection hids for collection inputs in dataset names #19229

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

bernt-matthias
Copy link
Contributor

@bernt-matthias bernt-matthias commented Dec 2, 2024

For input of dataset collections to data_collection inputs or data inputs with multiple="true" the dataset name (on_string) lists the HIDs of the datasets in the input collections. This makes it more difficult than necessary to understand the history. It would be better to list the input collections.

This PR does 2 things:

  • When the user inputs collections the dataset name refers to the input collections
  • Since collection is such a long word the dataset name would be quite long (in particular for 2 or more collection inputs). Hence I changed the on_string from "data 1, data 2, and data 3" to "dataset 1, 2, and 3" and analogous for collections.

Discussion:

  • Instead of dataset we could stick with data
  • Instead of collection we could use list .. to me it seems that the terms are used interchangeably .. ultimately we should decide for one
  • If one wants to be really fancy one could also distinguish pair / list (in the future)?

TODO:

Fixes #7467

Before (using the identifier_multiple test tool for multiple data input):

Screencast.from.02.12.2024.13.22.58.webm

After:

Screencast.from.02.12.2024.13.14.30.webm

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 25.0 milestone Dec 2, 2024
@bernt-matthias bernt-matthias force-pushed the collections-in-dataset-names branch 4 times, most recently from 8f03428 to 2ca2934 Compare December 2, 2024 13:57
@bernt-matthias bernt-matthias force-pushed the collections-in-dataset-names branch from 2ca2934 to 8000b81 Compare December 3, 2024 07:48
output "data 1, 2, and 3" instead of "data 1, data 2, and data 3"
@bernt-matthias bernt-matthias force-pushed the collections-in-dataset-names branch from 8000b81 to d70fe5c Compare December 3, 2024 12:05
@bernt-matthias bernt-matthias requested a review from a team December 18, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

on_string for collections selected in multiple=true inputs
1 participant