Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UP031 errors - Part 3 #19218

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Fix UP031 errors - Part 3 #19218

merged 1 commit into from
Nov 28, 2024

Conversation

nsoranzo
Copy link
Member

Also:

  • Small code refactorings.
  • Add type annotations.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@nsoranzo
Fix UP031 errors - Part 3
01e80fc 
Also:
- Small code refactorings.
- Add type annotations.
@github-actions github-actions bot added this to the 25.0 milestone Nov 28, 2024
@mvdbeek mvdbeek merged commit a648915 into galaxyproject:dev Nov 28, 2024
53 of 54 checks passed
@nsoranzo nsoranzo deleted the fix_UP031_errors_pt3 branch November 28, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdavcs jdavcs jdavcs approved these changes

Assignees
No one assigned
Labels
area/reports area/util area/workflows kind/enhancement
Projects
None yet
Milestone
25.0
Development

Successfully merging this pull request may close these issues.
3 participants
@nsoranzo @jdavcs @mvdbeek