Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UP031 errors - Part 1 #19194

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Fix UP031 errors - Part 1 #19194

merged 1 commit into from
Nov 25, 2024

Conversation

nsoranzo
Copy link
Member

reported by ruff 0.8.0 , see https://github.com/galaxyproject/galaxy/actions/runs/11983603574/job/33413355362 .

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@nsoranzo
Fix UP031 errors
26a4e14 
reported by ruff 0.8.0 .
@github-actions github-actions bot added this to the 25.0 milestone Nov 24, 2024
davelopez
davelopez approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@davelopez davelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@nsoranzo nsoranzo merged commit 9c486e4 into galaxyproject:dev Nov 25, 2024
54 of 55 checks passed
@nsoranzo nsoranzo deleted the fix_UP031_errors_pt1 branch November 25, 2024 12:04
@github-actions GitHub Actions
Copy link

This PR was merged without a "kind/" label, please correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davelopez davelopez davelopez approved these changes

Assignees
No one assigned
Labels
area/scripts area/testing/api area/testing/integration area/testing/selenium area/testing kind/enhancement
Projects
None yet
Milestone
25.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nsoranzo @davelopez