Use resource_path for datatypes linter #19188
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/documentation
area/testing
area/API
area/database
bernt-matthias
force-pushed
the
datatypes_linter_resource_path
branch
from
dad8120 to
24e185c
Compare
bernt-matthias
force-pushed
the
datatypes_linter_resource_path
branch
from
24e185c to
1459001
Compare
it seems to complicated to import Traversable
|
Unless this is a bug fix (I guess not?), it needs to target the dev branch. |
bernt-matthias
changed the title
nsoranzo
reviewed
Dec 16, 2024
|
|
||
|
|
||
| def _parse_datatypes(datatype_conf_path: str) -> Set[str]: | ||
| def _parse_datatypes(datatype_conf_path) -> Set[str]: |
There was a problem hiding this comment.
@bernt-matthias Unfortunately dropping the type annotation here hides issues when datatype_conf_path is processed by galaxy.util.parse_xml() . Do you mind if I open a separate PR that addresses them? I went down a rabbit hole for the last couple of days unfortunately :D
There was a problem hiding this comment.
Do you mind if I open a separate PR that addresses them?
No at all. Please do so.
I went down a rabbit hole for the last couple of days unfortunately
Good that you found out again.
4 tasks
|
Superseded by #19331 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#17600 (comment)
How to test the changes?
(Select all options that apply)
License