Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Venn Diagram to Script-Tag #19153

Merged
merged 2 commits into from
Nov 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions client/gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,8 @@ const STATIC_PLUGIN_BUILD_IDS = [
"scatterplot",
"tiffviewer",
"ts_visjs",
"venn",
];
const INSTALL_PLUGIN_BUILD_IDS = ["cytoscape", "ngl", "msa", "openlayers", "vizarr"]; // todo: derive from XML
const INSTALL_PLUGIN_BUILD_IDS = ["cytoscape", "ngl", "msa", "openlayers", "venn", "vizarr"]; // todo: derive from XML
const DIST_PLUGIN_BUILD_IDS = ["new_user"];
const PLUGIN_BUILD_IDS = Array.prototype.concat(DIST_PLUGIN_BUILD_IDS, STATIC_PLUGIN_BUILD_IDS);

Expand Down
9 changes: 6 additions & 3 deletions config/plugins/visualizations/venn/config/venn.xml
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,11 @@
<params>
<param type="dataset" var_name_in_template="hda" required="true">dataset_id</param>
</params>
<entry_point entry_point_type="chart" src="script.js" css="script.css"/>
<groups>
<requirements>
<requirement type="npm" version="0.0.2" package="@galaxyproject/venn"/>
</requirements>
<entry_point entry_point_type="script" src="dist/index.js" css="dist/index.css" />
<tracks>
<input>
<label>Provide a label</label>
<name>key</name>
Expand All @@ -28,5 +31,5 @@
<type>data_column</type>
<is_label>true</is_label>
</input>
</groups>
</tracks>
</visualization>
24 changes: 0 additions & 24 deletions config/plugins/visualizations/venn/package.json

This file was deleted.

93 changes: 0 additions & 93 deletions config/plugins/visualizations/venn/src/script.js

This file was deleted.

Loading
Loading