Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uv: Do not recalculate dependencies when exporting #19099

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

nsoranzo
Copy link
Member

@nsoranzo nsoranzo commented Nov 3, 2024

Originally opened this to fix a uv bug that seems to be already solved in 0.4.30 , so reusing the PR for a tiny optimisation.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 24.2 milestone Nov 3, 2024
@nsoranzo nsoranzo requested a review from a team November 4, 2024 15:22
@nsoranzo nsoranzo force-pushed the uv_workaround_for_6127 branch from 4c637ce to 1fadd2f Compare November 5, 2024 09:54
@nsoranzo nsoranzo changed the title Add workaround for uv bug uv: Do not recalculate dependencies when exporting Nov 5, 2024
@mvdbeek mvdbeek merged commit 3150e23 into galaxyproject:dev Nov 5, 2024
55 of 56 checks passed
@mvdbeek
Copy link
Member

mvdbeek commented Nov 5, 2024

Thank you!

Copy link

github-actions bot commented Nov 5, 2024

This PR was merged without a "kind/" label, please correct.

@nsoranzo nsoranzo deleted the uv_workaround_for_6127 branch November 5, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants