Fix auto-detect metadata from Edit Dataset Attributes panel

[davelopez]

I assume this was a leftover from #18626 since the overwrite parameter is now forced to True:

galaxy/lib/galaxy/tools/actions/metadata.py

Line 63 in e9f7316

overwrite = True

Fixes:

ERROR    galaxy.web.framework.decorators:decorators.py:361 Uncaught exception in exposed API method:
Traceback (most recent call last):
  File "/home/dlopez/dev/galaxy/lib/galaxy/web/framework/decorators.py", line 346, in decorator
    rval = func(self, trans, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/dlopez/dev/galaxy/lib/galaxy/webapps/galaxy/controllers/dataset.py", line 371, in set_edit
    job, *_ = trans.app.datatypes_registry.set_external_metadata_tool.tool_action.execute(
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: SetMetadataToolAction.execute() got an unexpected keyword argument 'overwrite'

Includes a selenium test.

How to test the changes?

• I've included appropriate automated tests.
• This is a refactoring of components with existing test coverage.
• Instructions for manual testing are as follows:
  • Click on Edit attributes on any dataset
  • Go to Datatypes tab
  • Click Auto-detect button
  • Observe there is no error

License

• I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

[davelopez]

Test failures unrelated

[bgruening]

Thanks @davelopez