Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FITS file table graph visualization plugin #19003

Merged

Conversation

francoismg
Copy link
Contributor

This plugin goal is to enable astrophysicists to explore and plot FITS file table and binary table data directly inside Galaxy.

To achieve this goal the plugin main package astrovisjs https://github.com/esg-epfl-apc/astrojsvis relies on :

All packages are loaded with npm and the plugin is built using webpack

Plugin main features are :

  • Explore any FITS file headers
  • Explore table and bintable data in table format
  • Load local files when dataset relies on external files data
  • Multiple files handling
  • Automatic column creation based on header data
  • Dynamically plot data using D3 or BokehJS from user choices (columns, ranges, error bars, log, .....)
  • Error bars support
  • Arithmetic columns creation
fits graph plugin 1 fits graph plugin 2 fits graph plugin columns fits graph plugin main

How to test the changes?

  • Instructions for manual testing are as follows:
    1. Load a FITS file containing at least one table or binary table HDU, example file available here https://www.astro.unige.ch/mmoda/gallery/data-products/1e-11451-6141-isgri-light-curve-61 at the very bottom of the page
    2. Launch plugin with selected file
    3. Select file from the "available files" column and use the "Add to plot" button at the bottom to switch it to "current files" column
    4. Select value for X Y axis and error bars if needed (for instance TIME, RATE, ERROR, TIMEDEL)
    5. Plot data using the "Generate" button

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@francoismg francoismg marked this pull request as ready for review October 25, 2024 03:50
@github-actions github-actions bot added this to the 24.2 milestone Oct 25, 2024
@volodymyrss
Copy link
Contributor

This plugin is made as part of EuroScienceGateway project in collaboration with @bgruening .

@bgruening bgruening requested a review from guerler November 1, 2024 16:08
@guerler
Copy link
Contributor

guerler commented Nov 13, 2024

This looks good to me. However, we don't need a custom mako file anymore for these cases. Please take a look at and cherry-pick this commit if it works for you:

guerler@0eeee1c

It removes the mako and changes the visualization entry point to script. Everything else looks good.

@volodymyrss
Copy link
Contributor

This looks good to me. However, we don't need a custom mako file anymore for these cases. Please take a look at and cherry-pick this commit if it works for you:

guerler@0eeee1c

It removes the mako and changes the visualization entry point to script. Everything else looks good.

@francoismg , does this work for you?

@francoismg
Copy link
Contributor Author

This looks good to me. However, we don't need a custom mako file anymore for these cases. Please take a look at and cherry-pick this commit if it works for you:
guerler@0eeee1c
It removes the mako and changes the visualization entry point to script. Everything else looks good.

@francoismg , does this work for you?

yes it seems good, I will try it locally and then make the changes

@francoismg
Copy link
Contributor Author

francoismg commented Nov 18, 2024

Everything seems to be working fine, changes have been made and pushed

@dannon dannon merged commit b635c7f into galaxyproject:dev Nov 19, 2024
51 of 53 checks passed
Copy link

This PR was merged without a "kind/" label, please correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants