Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using tracks and groups in visualization xml #18779

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

guerler
Copy link
Contributor

@guerler guerler commented Sep 5, 2024

While allowing for backward compatibility regarding the groups section use by nvd3/jqplot visualizations, this PR switches the default section name in visualization xmls to tracks for more clarity. This is a follow-up for #18651.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@guerler guerler added this to the 24.2 milestone Sep 5, 2024
@guerler guerler changed the title Use tracks instead of groups in visualization xml Allow using tracks and groups in visualization xml Sep 5, 2024
@guerler guerler marked this pull request as ready for review September 10, 2024 10:28
@guerler guerler force-pushed the use_tracks_instead_of_groups branch from 56c6287 to 37dc284 Compare September 13, 2024 00:59
@guerler guerler merged commit c84e014 into galaxyproject:dev Oct 2, 2024
50 of 55 checks passed
@guerler guerler deleted the use_tracks_instead_of_groups branch October 2, 2024 07:56
@guerler
Copy link
Contributor Author

guerler commented Oct 2, 2024

Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants