-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix MSA viz, new dependency specification options. #18760
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and all mangled.
… up installation.
… step is to get this all out of js anyway
mvdbeek
reviewed
Sep 4, 2024
mvdbeek
approved these changes
Sep 4, 2024
Are there any docs that would need updating ? |
@mvdbeek Yes, and I'll add that to the list -- we'll want to update GTN tutorials, etc., though we may want to shift those to using a template Sam has been working on as a base visualization. |
mvdbeek
approved these changes
Sep 4, 2024
This PR was merged without a "kind/" label, please correct. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primary driver was fixing the deployed MSA application on main -- this has been deployed to main in the usegalaxy branch as of last week and is working well to resolve our issues w/ msa. Specifying node package dependencies and relying on prebuilt visualization plugins (as implemented here) is going to make a huge difference in reliability moving forward.
In short, visualizations should prebuild and publish a
static
directory with whatever they need to run.In package.json, that's this new part:
Then the viz is published to npm like so: https://www.npmjs.com/@galaxyproject/msa
And then in the viz xml, we specify a particular version (or range, as appropriate) of plugin the viz is compatible with, like so:
These requirements will all get staged to the Galaxy server's static file serving without a build process required, avoiding all of the issues we've had with differing node versions on novel and/or archaic systems.
How to test the changes?
(Select all options that apply)
License