Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More typing, docs, and decomposition around tool execution #18758

Merged
merged 3 commits into from
Sep 7, 2024

Conversation

jmchilton
Copy link
Member

This helps cleanup #18745 and make it clearer what is happening there.

How to test the changes?

(Select all options that apply)

  • This is a refactoring of components with existing test coverage.

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jmchilton jmchilton added kind/refactoring cleanup or refactoring of existing code, no functional changes area/tool-framework labels Sep 2, 2024
@jmchilton jmchilton marked this pull request as ready for review September 2, 2024 19:54
@github-actions github-actions bot added this to the 24.2 milestone Sep 2, 2024
@jmchilton jmchilton marked this pull request as draft September 3, 2024 12:33
@jmchilton jmchilton marked this pull request as ready for review September 6, 2024 17:47
Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so exciting to see coming together :)


+--------------------------------+------------+---------------------------------+------------+-----------+
| Python Type | State for? | Object References | Validated? | xref |
+================================+============+=================================+============+===========+
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This table does not look complete. I assume you will fill that in your next PRs.

@bgruening
Copy link
Member

Test failures seem to be unrelated.

@mvdbeek mvdbeek merged commit 0e4e03a into galaxyproject:dev Sep 7, 2024
53 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tool-framework kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants