Fix new flake8-bugbear B039 and mypy type-var errors #18755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the following warning when running unit tests: ``` test/unit/webapps/test_request_scoped_sqlalchemy_sessions.py::test_request_scoped_sa_session_single_request test/unit/webapps/test_request_scoped_sqlalchemy_sessions.py::test_request_scoped_sa_session_exception test/unit/webapps/test_request_scoped_sqlalchemy_sessions.py::test_request_scoped_sa_session_concurrent_requests_sync test/unit/webapps/test_request_scoped_sqlalchemy_sessions.py::test_request_scoped_sa_session_concurrent_requests_async test/unit/webapps/test_request_scoped_sqlalchemy_sessions.py::test_request_scoped_sa_session_concurrent_requests_and_background_thread /usr/users/ga002/soranzon/software/nsoranzo_galaxy/.venv/lib/python3.10/site-packages/httpx/_client.py:1426: DeprecationWarning: The 'app' shortcut is now deprecated. Use the explicit style 'transport=ASGITransport(app=...)' instead. ``` See: https://github.com/encode/httpx/blob/master/CHANGELOG.md#0270-21st-february-2024
caused by the more precise type annotation of ``numpy.number`` comparison operators introduced in NumPy 2.1, see: python/typeshed#12562 Fix the following errors when running test_galaxy_packages on Python >=3.10: ``` galaxy/tool_util/verify/__init__.py:503: error: Value of type variable "SupportsRichComparisonT" of "max" cannot be "floating[Any]" [type-var] iou_list.append(max(cc1_iou_list)) ^~~~~~~~~~~~~~~~~ galaxy/tool_util/verify/__init__.py:532: error: Value of type variable "SupportsRichComparisonT" of "min" cannot be "floating[Any]" [type-var] return min(_multiobject_intersection_over_union(mask1, mask2, pin_labels)) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ```
github-actions
bot
added
area/testing
area/database
nsoranzo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix some
DeprecationWarnings.B039 fixes required for #18578 .
See individual commits for more details.
How to test the changes?
(Select all options that apply)
License