[24.1] Add error handling in WorkflowInvocationState
#18726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes galaxyproject#18723 Without this fix, if you get to the `WorkflowInvocationState` route for another user's invocation, there is a 404 error which is unhandled since there is a computed `invocation` ref that we constantly poll. Adding a `initialLoading` ref that ensures the first fetch for the invocation was valid (or the error is caught) fixes this.
ahmedhamidawan
changed the title
WorkflowInvocationState
jmchilton
approved these changes
Aug 21, 2024
dannon
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18723
Without this fix, if you get to the
WorkflowInvocationStateroute for another user's invocation, there is a 403 error which is unhandled since there is a computedinvocationref that we constantly poll. Adding ainitialLoadingref that ensures the first fetch for the invocation was valid (or the error is caught) fixes this.How to test the changes?
(Select all options that apply)
License