Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying multi-select workflow parameters #18715

Merged
merged 6 commits into from
Aug 28, 2024

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Aug 16, 2024

This just works, what's needed is:

  • Only allow multiple=true connections to actual multiple=true inputs
  • gxformat2 language to describe this
  • test

Closes #12233 (comment) and #16091 and #17957

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

This just works, what's needed is:

- Only allow multiple=true on actual multiple=true inputs
- gxformat2 language to describe this
- test
@mvdbeek mvdbeek marked this pull request as ready for review August 18, 2024 17:16
@github-actions github-actions bot added this to the 24.2 milestone Aug 18, 2024
@mvdbeek mvdbeek force-pushed the multiple_true_wf_param branch from 1da3b07 to 8750f06 Compare August 19, 2024 15:07
@jmchilton
Copy link
Member

Thank you for adopting the workflow tests so quick. I appreciate it! This looks great.

@mvdbeek mvdbeek merged commit dcdd716 into galaxyproject:dev Aug 28, 2024
53 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Advanced Workflow Input Constraints
3 participants