Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace types-pkg-resources with types-setuptools #18708

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

nsoranzo
Copy link
Member

All types-pkg-resources packages have been removed from PyPI:

https://pypi.org/project/types-pkg-resources/

in favour of types-setuptools.

This is breaking our Update dependencies GitHub workflow, see e.g.:

https://github.com/galaxyproject/galaxy/actions/runs/10328479305

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

All types-pkg-resources packages have been removed from PyPI:

https://pypi.org/project/types-pkg-resources/

in favour of types-setuptools.

This is breaking our Update dependencies GitHub workflow, see e.g.:

https://github.com/galaxyproject/galaxy/actions/runs/10328479305
@github-actions github-actions bot added this to the 24.2 milestone Aug 15, 2024
@nsoranzo nsoranzo requested a review from a team August 16, 2024 11:52
@mvdbeek mvdbeek merged commit 19bc932 into galaxyproject:dev Aug 16, 2024
52 of 55 checks passed
@mvdbeek
Copy link
Member

mvdbeek commented Aug 16, 2024

Thanks @nsoranzo!

@nsoranzo nsoranzo deleted the replace_types-pkg-resources branch August 16, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants