Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-couple XML from tool interface for test collections. #18676

Merged

Conversation

jmchilton
Copy link
Member

Keep more in JSON longer so we can apply less custom model objects for validation and stuff. The interface is returning more pure json now.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Keep more in JSON longer so we can apply less custom model objects for validation and stuff. The interface is returning more pure json now.
@jmchilton jmchilton added kind/refactoring cleanup or refactoring of existing code, no functional changes area/tool-framework labels Aug 9, 2024
@jmchilton jmchilton marked this pull request as ready for review August 9, 2024 18:39
@github-actions github-actions bot added this to the 24.2 milestone Aug 9, 2024
@mvdbeek mvdbeek merged commit 03d7be3 into galaxyproject:dev Aug 10, 2024
51 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tool-framework kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants