Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow connecting text param into data column parameter #18674

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Aug 9, 2024

If we really cared we could inspect the data_column param to see if we
should provide integers or column names ... but this is nice as is IMO.

Closes #16491

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jmchilton
Copy link
Member

jmchilton commented Aug 9, 2024

All column name parameters should be integers IMO - this is exactly the kind of things we should be getting away from not enabling IMO 😅😭.

Update: Those parameters all take integers just fine I believe - https://github.com/galaxyproject/galaxy/blob/dev/test/functional/tools/column_param.xml#L25. use_header_names should be an interface change IMO - not change the datatype of the input.

@mvdbeek
Copy link
Member Author

mvdbeek commented Aug 9, 2024

Sounds good to me, lets do it.

@mvdbeek mvdbeek force-pushed the text_into_data_column_select branch from f080d0a to dc632c3 Compare August 9, 2024 17:41
Copy link
Member

@jmchilton jmchilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the change - I really appreciate it.

@mvdbeek mvdbeek merged commit 1275c11 into galaxyproject:dev Aug 12, 2024
50 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't connect text parameter to data_column parameter in workflow editor
2 participants