Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another round of parameter model improvements. #18673

Merged
merged 14 commits into from
Aug 9, 2024

Conversation

jmchilton
Copy link
Member

See atomic commits for more details on each individual changes. These enhancements to the models are being derived from downstream work on applying the models to tool test case validation and workflow state validation in the standing structured tool state branch #17393.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool!

Copy link
Member

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks so clean 😍

@jmchilton jmchilton force-pushed the parameter_models_2 branch from 823842e to 250b60b Compare August 9, 2024 15:54
@jmchilton jmchilton force-pushed the parameter_models_2 branch from 250b60b to 39cb7f2 Compare August 9, 2024 16:48
@jmchilton jmchilton merged commit 287b889 into galaxyproject:dev Aug 9, 2024
51 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants