Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.0] Remove unnecessary assert for file_size #18669

Conversation

davelopez
Copy link
Contributor

Follow up to #18653

I've missed the relevant integration test failures in #18653 with the other "regular" failures while reviewing 😅

How to test the changes?

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

The file_size should be preserved in the database for traceability and other uses.
@github-actions github-actions bot added this to the 24.1 milestone Aug 9, 2024
@mvdbeek mvdbeek merged commit 591f36c into galaxyproject:release_24.0 Aug 9, 2024
44 of 51 checks passed
@davelopez davelopez deleted the 24.0_adapt_purged_size_integration_tests branch August 9, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants