Improve accept header API schema #18668

davelopez · 2024-08-09T10:18:07Z

It is now more explicit about what possible content types can be requested for some endpoints and the generated client schema will know those values.

How to test the changes?

I've included appropriate automated tests.
This is a refactoring of components with existing test coverage.
Instructions for manual testing are as follows:
1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

And make them more explicit. The wildcard */* will default to application/json.

To handle possible multiple comma-separated values in Accept header

mvdbeek · 2024-08-09T13:08:29Z

Nice, thank you!

davelopez added 2 commits August 9, 2024 12:08

Include Accept headers in API schema

3fa8741

And make them more explicit. The wildcard */* will default to application/json.

Fix accept_wildcard_defaults_to_json

aa33d29

To handle possible multiple comma-separated values in Accept header

davelopez added kind/enhancement kind/refactoring cleanup or refactoring of existing code, no functional changes area/API labels Aug 9, 2024

github-actions bot added this to the 24.2 milestone Aug 9, 2024

mvdbeek merged commit 6d291a9 into galaxyproject:dev Aug 9, 2024
53 of 56 checks passed

davelopez deleted the improve_accept_header_schema branch August 9, 2024 14:20

davelopez mentioned this pull request Aug 9, 2024

Upgrade openapi-typescript to 7.0.2 + swap to openapi-fetch #18532

Merged

15 tasks