Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.1] Fix extract workflow from history when implicit collection has no jobs #18661

Merged

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Aug 7, 2024

Fixes #18484.

It's not ideal on the one hand, but better to have a workflow with gaps
than an internal server error IMO. We do the same for datasets in some
non-terminal states.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

mvdbeek added 2 commits August 7, 2024 13:40
Fixes galaxyproject#18484.

It's not ideal on the one hand, but better to have a workflow with gaps
than an internal server error IMO. We do the same for datasets in some
non-terminal states.
@galaxyproject-sentryintegration

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: lib/galaxy/workflow/extract.py

Function Unhandled Issue
__summarize_dataset_collection IndexError: list index out of range /workflow/bui...
Event Count: 2

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions bot added this to the 24.1 milestone Aug 7, 2024
@mvdbeek
Copy link
Member Author

mvdbeek commented Aug 7, 2024

That's a lot of flaky tests, but I think they're all unrelated 😓

@mvdbeek mvdbeek merged commit cf211c1 into galaxyproject:release_24.1 Aug 7, 2024
43 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants