Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[24.0] Improve workflow creating/saving UX #18657

Merged
merged 2 commits into from
Aug 8, 2024
Merged

[24.0] Improve workflow creating/saving UX #18657

merged 2 commits into from
Aug 8, 2024

Conversation

ahmedhamidawan
Copy link
Member

@ahmedhamidawan ahmedhamidawan commented Aug 6, 2024 •
edited
Loading

The UX is improved with the following changes:

  • 🎨 For any unsaved changes in the workflow editor, the following text has been added next to the workflow name header: "(unsaved changes)"
  • 🐞 We ensure the reload page confirmation is triggered on changing workflow name and annotation as well.
  • 🐞 We also ensure that the router reload confirmation flag is reset on route change, since sometimes, the confirmation was not cleared when the route changed and the alert was shown needlessly.

Fixes #18609

improve_wf_save_ux_2.mp4

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 24.1 milestone Aug 6, 2024
davelopez
davelopez approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@davelopez davelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! Thank you @ahmedhamidawan

@ahmedhamidawan
[24.0] Improve workflow creating/saving UX
7d8a28c 
The UX is improved with the following changes:
- 🎨 For any unsaved changes in the workflow editor, the following text has been added next to the workflow name header: "_(unsaved changes)_"
- 🐞 We ensure the reload page confirmation is triggered on changing workflow name and annotation as well.
- 🐞 We also ensure that the router reload confirmation flag is reset on route change, since sometimes, the confirmation was not cleared when the route changed and the alert was shown needlessly.

Fixes galaxyproject#18609
@ahmedhamidawan
replace Create with Save when inside the editor
76cbfbe
@mvdbeek mvdbeek merged commit 6a7a889 into galaxyproject:release_24.0 Aug 8, 2024
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElectronicBlueberry ElectronicBlueberry ElectronicBlueberry left review comments

@dannon dannon dannon left review comments

@davelopez davelopez davelopez approved these changes

Assignees
No one assigned
Labels
area/UI-UX kind/bug kind/enhancement
Projects
None yet
Milestone
24.1
Development

Successfully merging this pull request may close these issues.
5 participants
@ahmedhamidawan @dannon @ElectronicBlueberry @davelopez @mvdbeek