Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.2] Strip whitespace when listifying admin users #18656

Merged

Conversation

jdavcs
Copy link
Member

@jdavcs jdavcs commented Aug 6, 2024

Strip whitespace around admin users when listifying, otherwise only first user is recognized:
admin_users: email1, email2: user "email2" will be stored with a leading whitespace and won't be recognized as an admin.

(Please replace this header with a description of your pull request. Please include BOTH what you did and why you made the changes. The "why" may simply be citing a relevant Galaxy issue.)
(If fixing a bug, please add any relevant error or traceback)
(For UI components, it is recommended to include screenshots or screencasts)

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jdavcs jdavcs added kind/bug area/configuration Galaxy's configuration system labels Aug 6, 2024
@github-actions github-actions bot added this to the 24.2 milestone Aug 6, 2024
@jdavcs jdavcs changed the base branch from dev to release_23.2 August 7, 2024 02:55
@bgruening bgruening merged commit ef4e32f into galaxyproject:release_23.2 Aug 7, 2024
51 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/configuration Galaxy's configuration system kind/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants