Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another shot at tool shed API fixes #18646

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

jmchilton
Copy link
Member

Longer term we've got get away from the ugly global data and invalid multi-threading of the hgweb_config_manager global instance of HgWebConfigManager.

If this fixes #18556 this time - we could replace all our repo_path calculation to skip that object using this mechanism and then... have one process that deals with keeping the hg web stuff in sync and just communicate with it using tasks? I really want Celery on the tool shed servers but I know our admin resources for the tool sheds are already tapped out 😿.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jmchilton jmchilton force-pushed the tool_shed_api_fixes branch 2 times, most recently from a3833c0 to 34394bc Compare August 5, 2024 16:21
@jmchilton jmchilton force-pushed the tool_shed_api_fixes branch from 34394bc to efe76b5 Compare August 5, 2024 16:24
@mvdbeek mvdbeek merged commit efe76b5 into galaxyproject:dev Aug 6, 2024
48 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tool state: wrong tool_config path loaded
2 participants