Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tighten user notification API response types #18599

Merged

Conversation

davelopez
Copy link
Contributor

@davelopez davelopez commented Jul 25, 2024

Part of #18532

This will exclude "broadcast" as a possible user notification response content as /api/notifications/* will never return a broadcast notification since we use /api/notifications/broadcast/* for those.

How to test the changes?

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

This will exclude "broadcast" as a possible user notification response.
@davelopez davelopez added kind/refactoring cleanup or refactoring of existing code, no functional changes area/API labels Jul 25, 2024
@github-actions github-actions bot added this to the 24.2 milestone Jul 25, 2024
@davelopez
Copy link
Contributor Author

All test failures are unrelated

@bgruening bgruening merged commit 2231152 into galaxyproject:dev Jul 26, 2024
51 of 56 checks passed
@davelopez davelopez deleted the improve_notifications_api_types branch July 26, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/API kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants