-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring your own file sources: Add the WebDAV template and configuration #18598
Bring your own file sources: Add the WebDAV template and configuration #18598
Conversation
@sanjaysrikakulam there is a @jmchilton can this go to 24.1? |
Cool, thanks! Unfortunately, I don't have the Galaxy environment. It's taking forever to create it due to some network error, Example:
Hence, the reason for the draft. I am unable to generate the diagrams and images at the moment. |
With prior advice of @bgruening , I just want to stress that this feature is very important for us in astro(particle)physics! |
f65dbd4
to
9e23ba7
Compare
lib/galaxy/files/sources/webdav.py
Outdated
from typing import ( | ||
Optional, | ||
Union, | ||
) | ||
|
||
from galaxy import config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this will work 🤔 this is importing the config module, but I guess you need an instance
of the app config with all the processed values available in the _open_fs method.
Maybe @mvdbeek or @jmchilton know how to reference the configuration values here, I don't know a good way of doing that but I might be missing something 😞
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just don't do it. Parse the config values in the config, this is too late. props
as serialized should contain all values ready to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll have a look at this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think #18909 is a version of what I was hoping for. Can we rebase this PR after that one is merged? Might be worth re-testing it on your end after that as well. Thanks for you patience - sorry to be a menace about this - I'm just very anxious about what we put in the database.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries John, we just want to do it as best as we can :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @jmchilton! Yes, I can rebase and fix this PR accordingly and would be happy to test it.
Adds WebDAV example template, configuration and updates the docs, and the file source model along with the client API schema
7a050cc
to
22863a1
Compare
This PR adds the
ToDo: