Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.0] Fix sqlalchemy statement in tooltagmanager reset output #18591

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

dannon
Copy link
Member

@dannon dannon commented Jul 23, 2024

Looks like we had a broken log statmeent here from the migration that few folks would have hit.
Error was:

sqlalchemy.exc.ArgumentError: Object <class 'galaxy.model.ToolTagAssociation'> is not legal as a SQL literal value

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@dannon dannon requested a review from jdavcs July 23, 2024 14:02
@dannon dannon marked this pull request as ready for review July 23, 2024 17:28
@github-actions github-actions bot added this to the 24.1 milestone Jul 23, 2024
@mvdbeek mvdbeek added kind/bug area/database Galaxy's database or data access layer and removed area/tool-framework labels Jul 25, 2024
@mvdbeek mvdbeek merged commit f15f028 into galaxyproject:release_24.0 Jul 25, 2024
45 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/database Galaxy's database or data access layer kind/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants