Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve datasets permissions API schema typing #18563

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Improve datasets permissions API schema typing #18563

merged 2 commits into from
Jul 19, 2024

Conversation

davelopez
Copy link
Contributor

@davelopez davelopez commented Jul 18, 2024 •
edited
Loading

Part of #18532

Full schema support for the 3 different aliases (access, access_ids, access_ids[]) to specify roles for dataset permissions. Enables full type check in the client schema.

Before After
Screenshot from 2024-07-18 16-10-54 image

How to test the changes?

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@davelopez davelopez added kind/enhancement kind/refactoring cleanup or refactoring of existing code, no functional changes area/API labels Jul 18, 2024
@github-actions github-actions bot added this to the 24.2 milestone Jul 18, 2024
@davelopez davelopez marked this pull request as draft July 18, 2024 15:02
@davelopez davelopez force-pushed the improve_datasets_permissions_api_typing branch from c1c8e62 to 63a2533 Compare July 18, 2024 16:52
@davelopez davelopez marked this pull request as ready for review July 18, 2024 16:54
@davelopez
Copy link
Contributor Author

Test failures are unrelated

@mvdbeek mvdbeek merged commit d7d85fd into galaxyproject:dev Jul 19, 2024
52 of 56 checks passed
@davelopez davelopez deleted the improve_datasets_permissions_api_typing branch July 19, 2024 09:33
@davelopez davelopez mentioned this pull request Aug 9, 2024
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/API kind/enhancement kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Milestone
24.2
Development

Successfully merging this pull request may close these issues.
2 participants
@davelopez @mvdbeek