Improvements to Tool Test Parsing #18560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmchilton
added
kind/refactoring
... small functions but they ensure we do the same things in and out of Galaxy.
jmchilton
force-pushed
the
test_parsing_work
branch
2 times, most recently
from
25ada78 to
ca53185
Compare
Add to tool_util, drop all the Galaxy mocking required using the older tool based logic.
jmchilton
force-pushed
the
test_parsing_work
branch
2 times, most recently
from
33bf596 to
71d5aa8
Compare
jmchilton
force-pushed
the
test_parsing_work
branch
from
71d5aa8 to
7d4c9f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on various commits that add some useful test cases, typing, and refactoring parsing logic for reuse out of
tools/__init__.pyandbasic.py, I've reworked the building ofToolTestDescriptionobjects to useToolSourceabstractions instead of theToolobject internals andbasic.pyabstractions.I kept trying to force Pydantic models in to the tool test APIs in the tool state branch but they kept breaking Galaxy tests. Bringing all this code under type checking and having a bunch of unit tests should help track down whatever problems those were. Being required to have Galaxy loads these descriptions in order to build test descriptions... has always been a little odd. Planemo should be able to reason about tool tests with the same abstractions as Galaxy now and catch more problems, etc... faster.
If you walk through the commits, you'll see I built up some before and after unit tests to make sure the test parsing changes didn't break anything. We will see if the framework tests catch anything else - if they do I'll add the relevant tests.
How to test the changes?
(Select all options that apply)
License