Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.0] Fix for not-null in 'column_list' object #18553

Merged

Conversation

hujambo-dunia
Copy link
Contributor

@hujambo-dunia hujambo-dunia commented Jul 17, 2024

#18486

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@mvdbeek
Copy link
Member

mvdbeek commented Jul 24, 2024

@hujambo-dunia Can you mark this as ready for review (if it is), rebase onto 24.0 (git rebase --onto release_24.0 HEAD~4) and then change the target branch to 24.0 ?

@hujambo-dunia hujambo-dunia force-pushed the fix-columnlist-datatype branch 2 times, most recently from 0d01a6d to c7e1cbf Compare July 24, 2024 21:54
@hujambo-dunia hujambo-dunia changed the base branch from dev to release_24.0 July 24, 2024 22:02
@hujambo-dunia hujambo-dunia marked this pull request as ready for review July 24, 2024 22:03
@github-actions github-actions bot added this to the 24.1 milestone Jul 24, 2024
@nsoranzo nsoranzo changed the title Fix for not-null in 'column_list' object [24.0] Fix for not-null in 'column_list' object Jul 25, 2024
@nsoranzo nsoranzo modified the milestones: 24.1, 24.2 Jul 25, 2024
@nsoranzo nsoranzo merged commit 1a0a706 into galaxyproject:release_24.0 Jul 25, 2024
52 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants