Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.1] Update h5web #18552

Merged
merged 4 commits into from
Aug 6, 2024
Merged

[24.1] Update h5web #18552

merged 4 commits into from
Aug 6, 2024

Conversation

dannon
Copy link
Member

@dannon dannon commented Jul 16, 2024

We were several major versions out of date and I'm guessing the h5py/h5web python dependencies just got too far ahead of the viz, causing #18530. In any event, in my local testing with this update it should be compatible with the provider now.

Will follow up with one more commit with better testing of this viz.

image

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@dannon dannon marked this pull request as ready for review July 19, 2024 14:08
@github-actions github-actions bot added this to the 24.1 milestone Jul 19, 2024
@dannon dannon mentioned this pull request Aug 5, 2024
@mvdbeek mvdbeek merged commit f8175ef into galaxyproject:release_24.1 Aug 6, 2024
45 of 50 checks passed
Copy link

github-actions bot commented Aug 6, 2024

This PR was merged without a "kind/" label, please correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants