Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mixed enhancements from CWL branch #18539

Merged
merged 4 commits into from
Jul 13, 2024
Merged

Mixed enhancements from CWL branch #18539

merged 4 commits into from
Jul 13, 2024

Conversation

nsoranzo
Copy link
Member

See commits for details.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@nsoranzo nsoranzo added kind/refactoring cleanup or refactoring of existing code, no functional changes area/cwl labels Jul 12, 2024
@github-actions github-actions bot added this to the 24.2 milestone Jul 12, 2024
@nsoranzo
Copy link
Member Author

The failing lib/galaxy_test/api/test_pages.py::TestPagesApi::test_pdf_when_service_available API test is unrelated, caused by Kozea/WeasyPrint#2200 and will be fixed when a new version of weasyprint is released on PyPI.

@nsoranzo nsoranzo merged commit 67fcb49 into galaxyproject:dev Jul 13, 2024
53 of 54 checks passed
@nsoranzo nsoranzo deleted the cwl_fixes branch July 13, 2024 16:35
@nsoranzo nsoranzo changed the title Random enhancements from CWL branch Mixed enhancements from CWL branch Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmchilton jmchilton jmchilton approved these changes

Assignees
No one assigned
Labels
area/cwl kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Milestone
24.2
Development

Successfully merging this pull request may close these issues.
2 participants
@nsoranzo @jmchilton