[24.1] Fix shared caches with extended metadata collection.

[jmchilton]

My guess is this should fix #18500? @sanjaysrikakulam any chance you can test if this improves the situation.

How to test the changes?

(Select all options that apply)

• I've included appropriate automated tests.
• This is a refactoring of components with existing test coverage.
• Instructions for manual testing are as follows:
  1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

• I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

[sanjaysrikakulam]

Sure! I will deploy the patch and update you.

[sanjaysrikakulam]

The patch works. I ran upload jobs and a tool on the uploaded data with no errors.

[sanjaysrikakulam]

Thank you! :)

[bgruening]

The failing tests are looking relevant :(

[bgruening]

Ok, this does not make sense for me, it actually works for @sanjaysrikakulam on the test server but fails here with the same error that we have seen previously here in this PR.

- Generated html report: file:///home/runner/work/galaxy/galaxy/galaxy%20root/run_unit_tests.html -
=========================== short test summary info ============================
FAILED test/unit/app/tools/test_metadata.py::TestMetadata::test_simple_output_directory - AttributeError: object_store_cache_size
FAILED test/unit/app/tools/test_metadata.py::TestMetadata::test_simple_output_extended - AttributeError: object_store_cache_size
FAILED test/unit/app/tools/test_metadata.py::TestMetadata::test_primary_dataset_output_extension_directory - AttributeError: object_store_cache_size
FAILED test/unit/app/tools/test_metadata.py::TestMetadata::test_primary_dataset_output_metadata_override_directory - AttributeError: object_store_cache_size
FAILED test/unit/app/tools/test_metadata.py::TestMetadata::test_primary_dataset_output_metadata_override_extended - AttributeError: object_store_cache_size
FAILED test/unit/app/tools/test_metadata.py::TestMetadata::test_list_discovery_extended - AttributeError: object_store_cache_size

[jmchilton]

Sorry - got distracted with workflow stuff. I think I've fixed the test. The only problem was with the test mocks not matching the real configuration object.

[github-actions]

This PR was merged without a "kind/" label, please correct.