Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.1] Don't call job_runner.stop_job on jobs in new state #18495

Merged

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Jul 4, 2024

These aren't submitted yet, no point in doing that. Fixes
https://sentry.galaxyproject.org/share/issue/ea06518238f1409eb22a8f502f9db557/:

AssertionError: External job id is None
  File "galaxy/jobs/runners/drmaa.py", line 375, in stop_job
    assert ext_id not in (None, "None"), "External job id is None"

(Please replace this header with a description of your pull request. Please include BOTH what you did and why you made the changes. The "why" may simply be citing a relevant Galaxy issue.)
(If fixing a bug, please add any relevant error or traceback)
(For UI components, it is recommended to include screenshots or screencasts)

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@mvdbeek mvdbeek changed the title Don't call job_runner.stop_job on jobs in new state [24.1] Don't call job_runner.stop_job on jobs in new state Jul 4, 2024
These aren't submitted yet, no point in doing that.
Fixes
https://sentry.galaxyproject.org/share/issue/ea06518238f1409eb22a8f502f9db557/:
```
AssertionError: External job id is None
  File "galaxy/jobs/runners/drmaa.py", line 375, in stop_job
    assert ext_id not in (None, "None"), "External job id is None"
```
@mvdbeek mvdbeek force-pushed the dont_call_stop_job_for_new_jobs branch from 70dad74 to cde7575 Compare July 4, 2024 11:24
@bgruening
Copy link
Member

Triggering test reruns, logs are gone.

@bgruening bgruening closed this Nov 1, 2024
@bgruening bgruening reopened this Nov 1, 2024
@github-actions github-actions bot added this to the 24.1 milestone Nov 1, 2024
@mvdbeek mvdbeek merged commit 6cc2fec into galaxyproject:release_24.1 Nov 15, 2024
94 of 99 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants