[24.0] Return generic message for password reset email

[ahmedhamidawan]

This prevents existence of a user account from being queryable through password reset. We now return None and display a generic message regardless of a prt being created or not.

Fixes #18475

How to test the changes?

(Select all options that apply)

• I've included appropriate automated tests.
• This is a refactoring of components with existing test coverage.
• Instructions for manual testing are as follows:
  1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

• I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

[jdavcs]

We no longer need the else clause: None will be returned by the outer conditional. To simplify, you could just have return None as the last line in the method's body, outside the conditionals' scope.

[nsoranzo]

Or just drop the else: clause completely, as returning None is the default.

[jdavcs]

Yes, but ( I think) mypy will fail with a missing return statement. The argument, I think, goes like this: if there is no previous return statement, it's OK to let it fall through to the default None; but if there is a return statement in a previous clause, adding an explicit return None improves readability. (I don't remember the source, but I do support the argument)

[jdavcs]

The unit test needs to be fixed too: this line will fail https://github.com/galaxyproject/galaxy/blob/dev/test/unit/app/managers/test_UserManager.py#L243

[jdavcs]

Looks good! Thank you for addressing the comments!