Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[22.05] pin bleach to 5.0.1 #18472

Merged
merged 1 commit into from
Jul 1, 2024
Merged

[22.05] pin bleach to 5.0.1 #18472

merged 1 commit into from
Jul 1, 2024

Conversation

bernt-matthias
Copy link
Contributor

@bernt-matthias bernt-matthias commented Jul 1, 2024 •
edited
Loading

22.05 is currently failing planemo tests (e.g. here) because bleach 5.0.0 has an error in its requirements that has been fixed here mozilla/bleach#655

  • 22.01 used bleach 4.x and
  • 23.0 used already 5.0.1 (but it is missing (?) in the dev requirements)

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@bernt-matthias
22.05 pin bleach to 5.0.1
95df247 
22.05 is currently failing planemo tests because bleach 5.0.0
has an error in its requirements that has been fixed here
mozilla/bleach#655
@bernt-matthias bernt-matthias changed the base branch from dev to release_22.05 July 1, 2024 08:31
@github-actions github-actions bot added this to the 23.0 milestone Jul 1, 2024
nsoranzo
nsoranzo approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@nsoranzo nsoranzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For those wondering why this has become an issue only now, it's because of changes in pip 24.1: https://pradyunsg.me/blog/2024/05/13/pip-24-1-betas/

@nsoranzo nsoranzo closed this Jul 1, 2024
@nsoranzo nsoranzo reopened this Jul 1, 2024
@mvdbeek mvdbeek merged commit 569d653 into galaxyproject:release_22.05 Jul 1, 2024
30 of 44 checks passed
@bernt-matthias bernt-matthias deleted the 22.05-bleach5.01 branch July 1, 2024 16:20
bernt-matthias added a commit to bernt-matthias/galaxy that referenced this pull request Jul 1, 2024
@bernt-matthias
pin celery to 5.2.3
e1b81d0 
- prior to [5.2.3](https://github.com/celery/celery/blame/v5.2.3/requirements/default.txt#L1) the pinning for pytz in celery was `pytz>0.dev.0` or `pytz>dev` which now creates problems:
- we updated the pinning to 5.2.3 in 22.01 anyway

see also galaxyproject#18472
and https://pradyunsg.me/blog/2024/05/13/pip-24-1-betas/
@bernt-matthias bernt-matthias mentioned this pull request Jul 1, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsoranzo nsoranzo nsoranzo approved these changes

Assignees
No one assigned
Labels
area/dependencies area/UI-UX kind/bug
Projects
None yet
Milestone
23.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bernt-matthias @nsoranzo @mvdbeek