Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds an option to restore activity bar defaults #18469

Merged
merged 4 commits into from
Jul 14, 2024

Conversation

guerler
Copy link
Contributor

@guerler guerler commented Jun 29, 2024

This PR adds a panel button to the activity settings panel. Clicking on this button enables users to restore the Activity Bar defaults.

activitybardefault

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@martenson
Copy link
Member

We use that arrow icon for "undo" in other context, could we use labeled button with "reset" or something similar to clarify what it does?

@guerler
Copy link
Contributor Author

guerler commented Jul 2, 2024

I would say that this is consistent. The undo/reset is only used in the workflow run form where users can reset the default input value. Additionally there is a tooltip and a modal warning before resetting the activity bar settings. Nevertheless I added a label. This seems to work given that there is only a single header button available.

@guerler guerler marked this pull request as ready for review July 9, 2024 10:10
@martenson martenson merged commit 4fec21e into galaxyproject:dev Jul 14, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants