-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve password reset UI/UX [GCC2024_COFEST] #18467
Open
laperlej
wants to merge
7
commits into
galaxyproject:dev
Choose a base branch
from
laperlej:reset_password_route
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laperlej
changed the title
Improve password reset UI/UX
[WIP] Improve password reset UI/UX
Jun 29, 2024
laperlej
changed the title
[WIP] Improve password reset UI/UX
[WIP] Improve password reset UI/UX [GCC2024_COFEST]
Jun 29, 2024
laperlej
changed the title
[WIP] Improve password reset UI/UX [GCC2024_COFEST]
Improve password reset UI/UX [GCC2024_COFEST]
Jun 29, 2024
laperlej
force-pushed
the
reset_password_route
branch
from
June 29, 2024 16:23
3592d39
to
102ea3d
Compare
laperlej
force-pushed
the
reset_password_route
branch
from
June 29, 2024 18:25
102ea3d
to
af457c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, password reset uses the login name/email field as an email field and the password reset link as a submit button. This dual purpose of the login form is not intuitive and can result in confusing error messages.
This PR adds a route for password reset at /login/reset_password, accessible from the reset password link at login/start.
In addition to this, the user experience for users with an expired password has been improved by sending them directly to the password change form. Previously, the redirect sent them to /root/login which just redirected them back to /login/start, dropping the query parameters along the way. This forced them to go through the token-based password reset flow instead of the expired id + current password flow that is already supported on both the frontend and backend.
How to test the changes?
(Select all options that apply)
License