Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve password reset UI/UX [GCC2024_COFEST] #18467

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

laperlej
Copy link
Collaborator

@laperlej laperlej commented Jun 28, 2024

Currently, password reset uses the login name/email field as an email field and the password reset link as a submit button. This dual purpose of the login form is not intuitive and can result in confusing error messages.

This PR adds a route for password reset at /login/reset_password, accessible from the reset password link at login/start.

In addition to this, the user experience for users with an expired password has been improved by sending them directly to the password change form. Previously, the redirect sent them to /root/login which just redirected them back to /login/start, dropping the query parameters along the way. This forced them to go through the token-based password reset flow instead of the expired id + current password flow that is already supported on both the frontend and backend.

image

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. Go to the login page
    2. Click on reset password
    3. Enter your email

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@laperlej laperlej changed the title Improve password reset UI/UX [WIP] Improve password reset UI/UX Jun 29, 2024
@laperlej laperlej changed the title [WIP] Improve password reset UI/UX [WIP] Improve password reset UI/UX [GCC2024_COFEST] Jun 29, 2024
@laperlej laperlej changed the title [WIP] Improve password reset UI/UX [GCC2024_COFEST] Improve password reset UI/UX [GCC2024_COFEST] Jun 29, 2024
@martenson
Copy link
Member

martenson commented Jun 29, 2024

nice idea, couple of comments below

  • If there is an email already entered in the form then after clicking "forgot password" the new form should have it prefilled so we don't make user re-enter it (it could also just directly submit it in that case)
  • A test for the new Vue component would be very welcome
  • It would be nice if the new form would be closely matching the width and design of the previous one. The transition between these two could be seamless.
Screenshot 2024-06-29 at 12 16 36 PM Screenshot 2024-06-29 at 12 16 46 PM

@laperlej laperlej marked this pull request as draft June 29, 2024 16:20
@laperlej laperlej force-pushed the reset_password_route branch from 3592d39 to 102ea3d Compare June 29, 2024 16:23
@laperlej laperlej force-pushed the reset_password_route branch from 102ea3d to af457c5 Compare June 29, 2024 18:25
@laperlej
Copy link
Collaborator Author

laperlej commented Jul 6, 2024

2024-07-05_22:01:31
2024-07-05_22:00:34
Hard to get identical screen grabs but they do use the same class for size now. I also added tests and kept the email field value.

@laperlej laperlej marked this pull request as ready for review July 6, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants