Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Podman 5 issue in sample job config file #18439

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

sveinugu
Copy link
Contributor

@sveinugu sveinugu commented Jun 25, 2024

Podman 5 by default stopped supporting containers to connect to host server. This PR adds a commandline argument to the sample job config file job_conf.yml.interactivetools.podman to re-enable loopback to host. This is needed by many interactive tools to connecting to the Galaxy API running at host

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • [ x ] Instructions for manual testing are as follows:
    Run an interactive tool that contacts the Galaxy API in the host machine, e.g. Jupyter, using the sample config.
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@sveinugu
Copy link
Contributor Author

@bernt-matthias Just wanted to inform you about this PR, which is a fix needed for podman v5 (it was the thing that broke my demo for Dannon, and which I mentioned in my GCC2024 talk...!). I believe I forgot to inform you about this. It is just a change to the sample file, so shouldn't be an issue to merge - if anyone notices! @mvdbeek?

@jdavcs jdavcs merged commit d6134fd into galaxyproject:dev Jul 1, 2024
47 of 52 checks passed
Copy link

github-actions bot commented Jul 1, 2024

This PR was merged without a "kind/" label, please correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants