Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for NumPy 2.0 #18422

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Prepare for NumPy 2.0 #18422

merged 1 commit into from
Jun 19, 2024

Conversation

nsoranzo
Copy link
Member

See https://blog.scientific-python.org/numpy/numpy2/

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added area/UI-UX area/database Galaxy's database or data access layer labels Jun 19, 2024
jdavcs
jdavcs approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@jdavcs jdavcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also enable ruff's NPY201 rule?

@nsoranzo
Copy link
Member Author

Should we also enable ruff's NPY201 rule?

That's already included in https://github.com/galaxyproject/galaxy/pull/18422/files#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711R202

@nsoranzo nsoranzo merged commit 25d6876 into galaxyproject:dev Jun 19, 2024
45 of 53 checks passed
@nsoranzo nsoranzo deleted the numpy2.0 branch June 19, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdavcs jdavcs jdavcs approved these changes

Assignees
No one assigned
Labels
area/database Galaxy's database or data access layer area/UI-UX kind/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nsoranzo @jdavcs