[24.1] Add TypedDict for JobsSummary #18418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes:
```
lib/galaxy/managers/jobs.py:866: error: Unsupported target for indexed
assignment ("object") [index]
rval["states"][row[0]] = row[1]
```
in mypy.
mvdbeek
force-pushed
the
fix_mypy_assignment_jobs_summary
branch
from
ac827cb to
b7a4a5f
Compare
davelopez
approved these changes
Jun 18, 2024
nsoranzo
reviewed
Jun 18, 2024
| @@ -26,6 +27,7 @@ | |||
| ) | |||
| from sqlalchemy.orm import aliased | |||
| from sqlalchemy.sql import select | |||
| from typing_extensions import TypedDict | |||
There was a problem hiding this comment.
It can be imported from typing since 24.1 is Python>=3.8 and this is not required by Pulsar?
There was a problem hiding this comment.
There are multiple other locations where we're importing TypedDict from typing_extensions, I'll make a pass at them in a separate PR.
jmchilton
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
in mypy.
(Please replace this header with a description of your pull request. Please include BOTH what you did and why you made the changes. The "why" may simply be citing a relevant Galaxy issue.)
(If fixing a bug, please add any relevant error or traceback)
(For UI components, it is recommended to include screenshots or screencasts)
How to test the changes?
(Select all options that apply)
License