Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.0] Fix collection map over status for dragged collections #18416

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Jun 17, 2024

Fixes #12614, which is the source of many templating errors such as
https://sentry.galaxyproject.org/share/issue/008a129bf7e44b3086491789f4bfb07e/:

NotFound: cannot find 'forward'
  File "galaxy/util/template.py", line 87, in fill_template
    return unicodify(t, log_exception=False)
  File "galaxy/util/__init__.py", line 1183, in unicodify
    value = str(value)
  File "Cheetah/Template.py", line 1053, in __unicode__
    return getattr(self, mainMethName)()
  File "cheetah_DynamicallyCompiledCheetahTemplate_1718305116_116218_60583.py", line 206, in respond

If we don't set batch and map_over_type (this is correctly done by the backend when building the parameter options from the history) we pass
in the whole collection, which likely won't have a forward element.

(Please replace this header with a description of your pull request. Please include BOTH what you did and why you made the changes. The "why" may simply be citing a relevant Galaxy issue.)
(If fixing a bug, please add any relevant error or traceback)
(For UI components, it is recommended to include screenshots or screencasts)

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Fixes galaxyproject#12614, which is the
source of many templating errors such as
https://sentry.galaxyproject.org/share/issue/008a129bf7e44b3086491789f4bfb07e/:

```
NotFound: cannot find 'forward'
  File "galaxy/util/template.py", line 87, in fill_template
    return unicodify(t, log_exception=False)
  File "galaxy/util/__init__.py", line 1183, in unicodify
    value = str(value)
  File "Cheetah/Template.py", line 1053, in __unicode__
    return getattr(self, mainMethName)()
  File "cheetah_DynamicallyCompiledCheetahTemplate_1718305116_116218_60583.py", line 206, in respond
```

If we don't set `batch` and `map_over_type` (this is correctly done by
the backend when building the parameter options from the history) we
pass
in the whole collection, which likely won't have a `forward` element.
@mvdbeek mvdbeek merged commit 4b17f1b into galaxyproject:release_24.0 Jun 17, 2024
43 of 52 checks passed
@jdavcs jdavcs added this to the 24.1 milestone Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants