Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.0] Assign default data extension on discovered collection output #18389

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Jun 13, 2024

Prevents #18383. To really close out #18383 we should probably add a migration that makes the column non-nullable and fills existing nulls with the "data" string.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@bernt-matthias
Copy link
Contributor

One could also think about making this a linter error. Not sure if this one .. or a new linter would be better.

@mvdbeek
Copy link
Member Author

mvdbeek commented Jun 13, 2024

it is a warning, but its not perfect since it doesn't cover galaxy.json

@mvdbeek
Copy link
Member Author

mvdbeek commented Jun 13, 2024

test failures are unrelated

@bernt-matthias
Copy link
Contributor

It actually has rudimentary galaxy.json support via _has_tool_provided_metadata. But the call to the function might need to be moved. And the check isn't perfect (and probably can't be).

@martenson martenson merged commit 2891489 into galaxyproject:release_24.0 Jun 18, 2024
46 of 51 checks passed
@jdavcs jdavcs added this to the 24.1 milestone Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants