Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.1] Fix duplicated requests when browsing files sources with pagination #18387

Conversation

davelopez
Copy link
Contributor

Partially addresses #18369

An additional unpaginated request was inadvertently triggered when browsing FilesSources which supports pagination.

Thank you @bwalkowi for reporting!

Before

RedundantFilesSourceRequestsBug

After

RedundantFilesSourceRequestsFixed

How to test the changes?

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@mvdbeek mvdbeek merged commit 222a2aa into galaxyproject:release_24.1 Jun 13, 2024
28 checks passed
@mvdbeek
Copy link
Member

mvdbeek commented Jun 13, 2024

Thank you @davelopez!

@davelopez davelopez deleted the 24.1_fix_files_source_listing_diplicated_requests branch June 13, 2024 12:33
@jdavcs jdavcs added this to the 24.1 milestone Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants